Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move from braces to brace-expansion #1302

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

43081j
Copy link

@43081j 43081j commented Feb 4, 2024

This replaces braces with brace-expansion, a much leaner and more actively maintained package.

This replaces `braces` with `brace-expansion`, a much leaner and more
actively maintained package.
@paulmillr
Copy link
Owner

What's there to maintain? It's probably much slower.

@43081j
Copy link
Author

43081j commented Feb 5, 2024

happy to find out if you like! i'll have a look this evening if i can

the leanness is more the reason to move. i do agree there's not much to maintain once this works, other than any security updates, etc.

@paulmillr
Copy link
Owner

Leanness is:

  1. Rewrite chokidar to drop globbing, decreasing amount of deps to a few.
  2. Switch to typescript.

Started in #1195, but never finished.

@43081j
Copy link
Author

43081j commented Feb 5, 2024

do you want any help?

braces is small fish but still responsible for dependency bloat either way. if we can solve that by dropping globbing altogether though, i'm happy to go in whatever direction it is you want

you were right though, brace-expansion in particular is slightly slower than braces. so i'll go open a PR in brace-expansion to fix that whether we use it here or not 👍

@paulmillr
Copy link
Owner

Yes, if anyone can help on the rewrite, it would be highly appreciated. Non-trivial task.

@43081j
Copy link
Author

43081j commented Feb 5, 2024

sure no worries, i'll take a look at it. non trivial esm/ts conversions are my kind of thing 👀

@43081j
Copy link
Author

43081j commented Feb 5, 2024

for anyone curious, i've opened a perf fix in juliangruber/brace-expansion#64 which makes it out-perform braces by a fair amount

@paulmillr paulmillr force-pushed the master branch 2 times, most recently from 368cb02 to 7c50e25 Compare February 6, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants