feat(venmo): relax eligibility #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
reviewed
May 17, 2024
src/funding/venmo/config.jsx
Outdated
| @@ -42,7 +42,6 @@ export function getVenmoConfig(): FundingSourceConfig { | |||
| experiment.venmoWebEnabled === false | |||
| ) { | |||
| return { | |||
| native: true, | |||
| popup: true, | |||
There was a problem hiding this comment.
If device is Mobile & Venmo Web is disabled, then require popup? Am I reading that right? From this little snippet it seems like native should be true and popup should be false but I am likely missing context of the bigger picture
I just read your description though, is this saying:
we may still app-switch, but if we can't popup then definitely don't continue
There was a problem hiding this comment.
@wsbrunson By removing native, it is saying SFVC is ok. We will catch that just prior to app switching. If in SFVC there, then we will fallback to web. Popup relates to WebView and want to keep that there.
wsbrunson
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relaxing venmo first render eligibility now that Venmo web experience is live and can better manage fallback from native app switch.
PR
https://paypal.atlassian.net/browse/DTVP-75
**Note:**The last requirement, 1d, will be implemented at a later date.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!