Make Venmo ineligible if shipping callback is present & displayOnly includes "vaultable" 👾 #2394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
displayOnly: ["vaultable"]
, we should not show the venmo button.hasShippingCallback**_ - We weren't passing
onShippingAddressChangeor
onShippingOptionsChange` to SCNW, but we needed a way to know if a shipping callback existed. Instead of passing these callbacks themselves, I just added this boolean one query param. S/O to @wsbrunson for this idea!isFundingEligible
.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
JIRA: DTPPCPSDK-2321
Reproduction Steps (if applicable)
Setup
npm run build
npm run debug
Testing
displayOnly: ["vaultable"]
to your buttons component. You should not see the Venmo button❤️ Thank you!