-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add button session id to modals #1078
base: develop
Are you sure you want to change the base?
feat: add button session id to modals #1078
Conversation
src/utils/logger.js
Outdated
@@ -27,8 +27,7 @@ function generateLogPayload(account, { meta, events: bizEvents, tracking }) { | |||
const components = Object.entries(meta) | |||
.filter(([, component]) => component.account === account) | |||
.map(([index, component]) => { | |||
const { type, messageRequestId, stats = {}, trackingDetails } = component; | |||
|
|||
const { type, buttonSessionId = undefined, messageRequestId, stats = {}, trackingDetails } = component; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need = undefined
? That should already be the case when destructuring from an object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it, i thought attempting destructuring a variable that is undefined would cause a failure. I added a comment just in case
Description
add button session id to modals
Screenshots
Testing instructions