parse edition syntax (#300)

pbkit · Dec 10, 2023 · dc5949d · dc5949d
1 parent aa80096
commit dc5949d
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 0 deletions.
diff --git a/core/ast/index.ts b/core/ast/index.ts
@@ -47,6 +47,7 @@ export type Node =
 
 type index_Node =
   | Syntax
+  | Edition
   | Import
   | Package
   | Option
@@ -72,6 +73,7 @@ export type Statement =
 
 export type TopLevelStatement =
   | Syntax
+  | Edition
   | Import
   | Package
   | Option
@@ -96,6 +98,16 @@ export interface Syntax extends StatementBase {
   semi: Semi;
 }
 
+export interface Edition extends StatementBase {
+  type: "edition";
+  keyword: Keyword;
+  eq: Token;
+  quoteOpen: Token;
+  edition: Token;
+  quoteClose: Token;
+  semi: Semi;
+}
+
 export interface Import extends StatementBase {
   type: "import";
   keyword: Keyword;

diff --git a/core/parser/proto.ts b/core/parser/proto.ts
@@ -40,6 +40,7 @@ export function parse(text: string): ParseResult {
   parser.on("comment", (comment) => comments.push(comment));
   const statements = acceptStatements<ast.TopLevelStatement>(parser, [
     acceptSyntax,
+    acceptEdition,
     acceptImport,
     acceptPackage,
     acceptOption,
@@ -632,6 +633,43 @@ function acceptSyntax(
   };
 }
 
+function acceptEdition(
+  parser: ProtoParser,
+  leadingComments: ast.CommentGroup[],
+  leadingDetachedComments: ast.CommentGroup[],
+): ast.Edition | undefined {
+  const keyword = acceptKeyword(parser, "edition");
+  if (!keyword) return;
+  skipWsAndComments(parser);
+  const eq = parser.expect("=");
+  skipWsAndComments(parser);
+  const quoteOpen = parser.expect(/^['"]/);
+  const edition = parser.expect(/^[^'"]+/);
+  const quoteClose = parser.expect(/^['"]/);
+  skipWsAndComments(parser);
+  const semi = expectSemi(parser);
+  const trailingComments = acceptTrailingComments(parser);
+  return {
+    ...mergeSpans([
+      leadingDetachedComments,
+      leadingComments,
+      keyword,
+      semi,
+      trailingComments,
+    ]),
+    leadingComments,
+    trailingComments,
+    leadingDetachedComments,
+    type: "edition",
+    keyword,
+    eq,
+    quoteOpen,
+    edition,
+    quoteClose,
+    semi,
+  };
+}
+
 function acceptImport(
   parser: ProtoParser,
   leadingComments: ast.CommentGroup[],

diff --git a/core/visitor/index.ts b/core/visitor/index.ts
@@ -5,6 +5,7 @@ export interface Visitor {
   visitProto: VisitFn<ast.Proto>;
   visitTopLevelStatement: VisitFn<ast.TopLevelStatement>;
   visitSyntax: VisitFn<ast.Syntax>;
+  visitEdition: VisitFn<ast.Edition>;
   visitImport: VisitFn<ast.Import>;
   visitPackage: VisitFn<ast.Package>;
   visitOption: VisitFn<ast.Option>;
@@ -107,6 +108,16 @@ export const visitor: Visitor = {
       visitor.visitSemi(visitor, node.semi);
     });
   },
+  visitEdition(visitor, node) {
+    visitStatementBase(visitor, node, () => {
+      visitor.visitKeyword(visitor, node.keyword);
+      visitor.visitToken(visitor, node.eq);
+      visitor.visitToken(visitor, node.quoteOpen);
+      visitor.visitToken(visitor, node.edition);
+      visitor.visitToken(visitor, node.quoteClose);
+      visitor.visitSemi(visitor, node.semi);
+    });
+  },
   visitImport(visitor, node) {
     visitStatementBase(visitor, node, () => {
       visitor.visitKeyword(visitor, node.keyword);