Skip to content

Commit

Permalink
Gemfile: Lock nokogiri to Ruby 2.6-compatible version (#44)
Browse files Browse the repository at this point in the history
This paves the way for #40.
We could outright upgrade Nokogiri in this PR, but I'll let Dependabot
take the credit for that since it was the one who prompted the upgrade
in the first place. :)

The problem with #40 as it
currently stands is that it tries to use Nokogiri 1.16.0, which has
dropped both Ruby 2.6 support (in 1.14.0) and Ruby 2.7 (in 1.16.0). Both
of these Ruby versions have reached EOL, so we should certainly upgrade
our Ruby version as well but let's begin with addressing these
security-related PRs first.
  • Loading branch information
perlun committed Jan 6, 2024
1 parent 8dbe91e commit f9db825
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ gem 'jekyll', '~> 3.8'
gem 'jemoji', '~> 0.13'
gem 'redcarpet', '~> 3.6'
gem 'pygments.rb', '~> 1.1'

# 1.14.0 is Ruby 2.7 only
gem 'nokogiri', '< 1.14.0'
3 changes: 2 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@ DEPENDENCIES
jekyll-multiple-languages-plugin!
jekyll-paginate (~> 1.1)
jemoji (~> 0.13)
nokogiri (< 1.14.0)
pygments.rb (~> 1.1)
redcarpet (~> 3.6)

BUNDLED WITH
2.2.0
2.3.20

0 comments on commit f9db825

Please sign in to comment.