feat: support del hotkey for deleting photos in detail view #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@til-schneider can you review this PR please? |
| @@ -75,7 +76,7 @@ export default class PhotoDetailBody extends React.Component<Props, State> { | |||
| constructor(props: Props) { | |||
| super(props) | |||
| bindMany(this, 'onLoadingStateChange', 'onResize', 'onTextureChange', 'onTogglePhotoSelected', | |||
| 'setPhotoPosition', 'enterCropMode', 'onPhotoWorkEdited', 'onCropDone') | |||
| 'setPhotoPosition', 'enterCropMode', 'onPhotoWorkEdited', 'onCropDone', "moveToTrash") | |||
There was a problem hiding this comment.
Please use single ticks, so the code looks uniform
| import { msg } from 'common/i18n/i18n' | ||
| import { formatNumber } from 'common/util/TextUtil' | ||
|
|
||
| export function movePhotosToTrash(photos: PhotoCollection | null | undefined, controller: PhotoActionController) { |
There was a problem hiding this comment.
Please don't introduce a new module here. Instead you can add an optional showToast?: boolean parameter to PhotoActionController.movePhotosToTrash and put the toast code to the defaultPhotoActionController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the "del" hotkey in photo detail view so that both browsing the photos and deleting the photos can be done with the keyboard only.