Eliminate unneeded work when missing signing keys #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 is a legitimate value for maxAge. If there are no signing keys, you can abort sooner. There's no need to parse the signature cookie, etc. if you already know you will fail.
dougwilson
suggested changes
May 20, 2018
dougwilson
changed the title
dougwilson
approved these changes
Sep 10, 2018
|
Hi @smcmurray sorry this fell off my radar. Thanks for moving the maxAge into a different PR. I was actually just about to merge this, but realized it actually has a behavior change with this: When reading a non-signed cookie with I think this PR is the right change of behavior, though, and will put it into the 0.8.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 is a legitimate value for maxAge.
If there are no signing keys, you can abort sooner. There's no need to parse the signature cookie, etc. if you already know you will fail.