Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for reverseRelation in enrichLayoutDefinition #17072

Open
wants to merge 1 commit into
base: 11.x
Choose a base branch
from
Open

Add check for reverseRelation in enrichLayoutDefinition #17072

wants to merge 1 commit into from

Conversation

sl0wlydeadly
Copy link

Changes in this pull request

Resolves #17071

Additional info

Adding a check in enrichLayoutDefinition in ManyToManyObjectRelation.php needed to pass the selected visible fields for the ReverseObjectRelation

@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sl0wlydeadly
Copy link
Author

recheck

@sl0wlydeadly
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sl0wlydeadly sl0wlydeadly mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Pimcore:ToDo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add admin async loading to reverseObjectRelation
2 participants
@sl0wlydeadly @wisconaut