-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: trigger stats load on a column in determinate mode to make sure analyze row count is available (#51435) #53398
planner: trigger stats load on a column in determinate mode to make sure analyze row count is available (#51435) #53398
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
2bcff67
to
ebd22d3
Compare
/test all |
@time-and-fate: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@time-and-fate: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53398 +/- ##
================================================
Coverage ? 72.0311%
================================================
Files ? 1411
Lines ? 409913
Branches ? 0
================================================
Hits ? 295265
Misses ? 94809
Partials ? 19839
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: time-and-fate, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #51435
What problem does this PR solve?
Issue Number: close #48257
Problem Summary:
Currently, if there are no predicates on one table, no stats loading will be triggered.
But in the determinate mode, if there are no full-loaded stats on this table, we are unable to get the "analyze row count".
This won't be a problem in most times, but it may cause a problem if it's joined with other tables.
What changed and how does it work?
In the determinate mode, if:
then we arbitrarily choose one column to trigger stats loading.
This is implemented in
collectPredicateColumnsPoint
while effective in both sync/async load modes.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.