Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: trigger stats load on a column in determinate mode to make sure analyze row count is available (#51435) #53398

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51435

What problem does this PR solve?

Issue Number: close #48257

Problem Summary:

Currently, if there are no predicates on one table, no stats loading will be triggered.
But in the determinate mode, if there are no full-loaded stats on this table, we are unable to get the "analyze row count".
This won't be a problem in most times, but it may cause a problem if it's joined with other tables.

What changed and how does it work?

In the determinate mode, if:

  1. no sync stats loading is triggered on a table, and
  2. there are no full-loaded stats on this table

then we arbitrarily choose one column to trigger stats loading.

This is implemented in collectPredicateColumnsPoint while effective in both sync/async load modes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@time-and-fate
Copy link
Member

/test all

Copy link

tiprow bot commented May 20, 2024

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@time-and-fate
Copy link
Member

/test unit-test

Copy link

tiprow bot commented May 20, 2024

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 76.62338% with 18 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@08ee45d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53398   +/-   ##
================================================
  Coverage               ?   72.0311%           
================================================
  Files                  ?       1411           
  Lines                  ?     409913           
  Branches               ?          0           
================================================
  Hits                   ?     295265           
  Misses                 ?      94809           
  Partials               ?      19839           
Flag Coverage Δ
unit 72.0311% <76.6233%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4792% <0.0000%> (?)

Copy link

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [time-and-fate,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-20 12:30:57.476860997 +0000 UTC m=+2088411.233996570: ☑️ agreed by winoros.
  • 2024-05-20 18:21:19.426593276 +0000 UTC m=+2109433.183728849: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit 00a460e into pingcap:release-7.5 May 20, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants