*: not load unnecessay data during the non-lite-init-stats #53399
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
sig/planner
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53399 +/- ##
================================================
+ Coverage 72.5268% 74.6174% +2.0906%
================================================
Files 1505 1505
Lines 429830 431474 +1644
================================================
+ Hits 311742 321955 +10213
+ Misses 98799 89587 -9212
- Partials 19289 19932 +643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
size/M
pkg/statistics/handle/bootstrap.go
Outdated
| @@ -174,6 +174,68 @@ func (h *Handle) initStatsHistograms4ChunkLite(is infoschema.InfoSchema, cache s | |||
| } | |||
| } | |||
|
|
|||
| func (h *Handle) initStatsHistograms4ChunkConcurrency(is infoschema.InfoSchema, cache statstypes.StatsCache, iter *chunk.Iterator4Chunk) { | |||
There was a problem hiding this comment.
initStatsHistograms4ChunkConcurrency is the same as initStatsHistograms4Chunk. But it will not read is_index.
There was a problem hiding this comment.
What do you mean by concurrency? Can we just add a parameter to initStatsHistograms4Chunk to avoid copying the code?
There was a problem hiding this comment.
concurrency means it is in concurrency mode.
It is hard that their code is not aligned.
hawkingrei
requested review from
winoros and
hi-rustin
and removed request for
winoros
|
/retest |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
0520init-stats
branch
from
bc6617a
to
8a4f251
Compare
ti-chi-bot
bot
added
size/M
| @@ -322,7 +322,7 @@ func (h *Handle) initStatsHistogramsByPaging(is infoschema.InfoSchema, cache sta | |||
| } | |||
| }() | |||
| sctx := se.(sessionctx.Context) | |||
| sql := "select HIGH_PRIORITY table_id, is_index, hist_id, distinct_count, version, null_count, cm_sketch, tot_col_size, stats_ver, correlation, flag, last_analyze_pos from mysql.stats_histograms where table_id >= %? and table_id < %?" | |||
| sql := "select HIGH_PRIORITY table_id, is_index, hist_id, distinct_count, version, null_count, cm_sketch, tot_col_size, stats_ver, correlation, flag, last_analyze_pos from mysql.stats_histograms where table_id >= %? and table_id < %? and is_index=1" | |||
There was a problem hiding this comment.
Could you please add some comments here to explain why we chose to do it? Thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hi-rustin, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-7.5 |
|
/cherrypick release-8.1 |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #53425
Problem Summary:
What changed and how does it work?
After #53298, We know that TiDB cannot load the topn when to init stats and have to load it when to sync load. so we need not load hists for the not-index column when to init stats.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.