-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toast): message VNode support #5707
Closed
antlionguard
wants to merge
498
commits into
primefaces:v4
from
antlionguard:feat/toast-message-vnode-support
Closed
feat(toast): message VNode support #5707
antlionguard
wants to merge
498
commits into
primefaces:v4
from
antlionguard:feat/toast-message-vnode-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
antlionguard
changed the title
Toast message VNode support
feat(toast): message VNode support
May 8, 2024
tugcekucukoglu
added
the
Resolution: Needs Revision
The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
label
May 16, 2024
maybe this feature can be added to all components. table, listbox etc. but this seems to be a bit of a hard work. but if you need help if you are going to do something like this, I will be happy to help. |
…/antlionguard/primevue into feat/toast-message-vnode-support
I just ruined all pr making rebase :d i will create new pr for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Resolution: Needs Revision
The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added VNode support to Toast message for making Toast more flexible usage.
For example
resolves #5708