-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging forks that were never merged into the official pug-cli #93
Open
svallory
wants to merge
28
commits into
pugjs:master
Choose a base branch
from
tokilabs:merging-forks
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,057
−517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@anduh/pug-cli - PUG 3 - 1.0.0
Merge contributions from @Anduh
…de recommends to use fs.watch instead
Merge contributions from anthony-tron/yaml support
Add contributions from funai/master to allow YAML frontmatter
Previous implementation used 'lstatSync' which returns stat info about link itself, not the file that it refers to. That behaviour didn't allow to use the tool in case of separate build (source and build dirs are separate, and sources linked back into build directory). As workaround there we could provide file content through stdin, but that approach has limitations: - you cannot process multiple files at once - you cannot use 'include' directives This commit changes the use of 'lstatSync' to 'statSync' which makes symlink files be processed as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case anyone in the official repository wants an easy merge...
If not, you can get all this by from tokilabs/pug3-cli by installing the npm package
@tokilabs/pug3-cli
Here's a list of the merged contributions:
-O | --obj
option (Closes Support hot reload for object files (JS, JSON, YAML) #89)extends
from frontmatterlayout