feat: allow creating ElementHandles from the accessibility tree snapshot #12233
+134
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
main
branch
4 times, most recently
from
2ff1e4f
to
e0932e5
Compare
OrKoN
force-pushed
the
orkon/a11y-elementhandle
branch
from
09aaecf
to
5c10be4
Compare
OrKoN
force-pushed
the
orkon/a11y-elementhandle
branch
from
5c10be4
to
1fad560
Compare
OrKoN
changed the title
OrKoN
changed the title
Comment on lines
+451
to
+458
| elementHandle: async (): Promise<ElementHandle | null> => { | ||
| if (!this.payload.backendDOMNodeId) { | ||
| return null; | ||
| } | ||
| return (await this.#realm.adoptBackendNode( | ||
| this.payload.backendDOMNodeId | ||
| )) as ElementHandle<Element>; | ||
| }, |
There was a problem hiding this comment.
How about something like this, so we change the struct less?
And you are can just check 'elementHandle' in X
Suggested change
| elementHandle: async (): Promise<ElementHandle | null> => { | |
| if (!this.payload.backendDOMNodeId) { | |
| return null; | |
| } | |
| return (await this.#realm.adoptBackendNode( | |
| this.payload.backendDOMNodeId | |
| )) as ElementHandle<Element>; | |
| }, | |
| ...{ this.payload.backendDOMNodeId ? { | |
| elementHandle: async (): Promise<ElementHandle> => { | |
| return (await this.#realm.adoptBackendNode( | |
| this.payload.backendDOMNodeId | |
| )) as ElementHandle<Element>;} | |
| } | |
| : {} | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3641