-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show else
prefix for instance chain items in docs
#3715
base: master
Are you sure you want to change the base?
Conversation
Yes please, good call. |
The solution in bc3cc4e is not very elegant, but works. Basically the problem is, that rendering of the ChildDeclaration needs to know if the parent declaration is a TypeClass. Alternatively, I could pass the Parent declaration to |
This is actually quite a bit more subtle than I first expected. I think what we have here is still not quite right, for a couple of reasons:
I'm trying to come up with some convincing examples. I think the correct approach here may be to represent the entire chain as a single |
bc3cc4e
to
7943881
Compare
New version is improved in pretty much every way:
TODO:
|
c00e543
to
b8805c8
Compare
Fix for Issue #3605
example:
Changes
Bool
to ChildInstance Constructorchained
to JSON representation, with default valueFalse
for backwards-compatabilityelse
keywordNotes
Displaying the instances of a type can look weird because the
else
prefix has no meaning there. I would suggest hiding theelse
keyword when displaying anywhere except a type class context