Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate warnings as well? #45

Open
mjpieters opened this issue Nov 23, 2021 · 6 comments · May be fixed by #68
Open

Annotate warnings as well? #45

mjpieters opened this issue Nov 23, 2021 · 6 comments · May be fixed by #68

Comments

@mjpieters
Copy link

Can warnings captured by pytest also be turned into annotations? I’m referring to the warnings output at the end of a pytest run.

Pytest offers a hook for such warnings. They could be turned into annotations using the warning workflow command.
@utgwkk
Copy link
Member

utgwkk commented Dec 8, 2021

Looks like good. It would be better that we can suppress warning annotations with some options.

@edgarrmondragon
Copy link
Contributor

Started a PR #68

@edgarrmondragon edgarrmondragon linked a pull request May 17, 2023 that will close this issue
Open
@oliv10
Copy link

oliv10 commented May 14, 2024 •
edited

I would like to see this implemented. And the PR has been stale for nearly a year... and is fully functional, I pulled and tested it myself. Works as expected.

+1

Screenshot (Ran in a matrix, works great)

image

@edgarrmondragon
Copy link
Contributor

I would like to see this implemented. And the PR has been stale for nearly a year... and is fully functional, I pulled and tested it myself. Works as expected.

+1

Screenshot (Ran in a matrix, works great)
image

@oliv10 thanks for giving it a try! Tests are failing for pytest 7.4.x on that PR, so I need to make some time to fix that. It's probably also worth adding tests for 8.x in a separate PR.

@oliv10
Copy link

oliv10 commented May 15, 2024

@edgarrmondragon no problem! Just to make note for you, I used pytest 8.2.0 in the previous screenshot.

@henryiii
Copy link
Contributor

The bug (#81 and more detail in #76) only affects certain annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Annotate warnings edgarrmondragon/pytest-github-actions-annotate-failures
5 participants
@mjpieters @utgwkk @henryiii @edgarrmondragon @oliv10