Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate warnings #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Annotate warnings #68

wants to merge 3 commits into from

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Feb 8, 2023 •
edited

  • Supported only in pytest >= 6.0.0 (docs)
  • Adds an --exclude-warning-annotations option to exclude warning annotations

Closes #45

@edgarrmondragon edgarrmondragon force-pushed the feat/annotate-warnings branch 4 times, most recently from 20f27ab to a70c269 Compare February 8, 2023 23:31
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 8, 2023 23:34
@edgarrmondragon edgarrmondragon marked this pull request as draft February 9, 2023 00:25
@edgarrmondragon edgarrmondragon force-pushed the feat/annotate-warnings branch 2 times, most recently from 87145ee to ae9b957 Compare February 9, 2023 01:03
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 9, 2023 01:06
@edgarrmondragon edgarrmondragon mentioned this pull request Feb 9, 2023
Open
@henryiii
Copy link
Contributor

Yeah, I think --exclude-warning-annotations or something else specific to this plugin only would be better.

@edgarrmondragon
Copy link
Contributor Author

Yeah, I think --exclude-warning-annotations or something else specific to this plugin only would be better.

Done 494dca7!

@edgarrmondragon
Copy link
Contributor Author

this is ready for another review @henryiii 🙂

@edgarrmondragon @henryiii
Annotate warnings
132083d 
- Refactor workflow command generation
- Skip warning annotations in Pytest < 6.0.0
@edgarrmondragon @henryiii
Rename option to --exclude-warning-annotations
dd855a1
@henryiii
Copy link
Contributor

FYI, we need to hide our warnings to get though CI. Mostly on pytest 6.

edgarrmondragon
edgarrmondragon commented May 16, 2024
View reviewed changes
pytest_github_actions_annotate_failures/plugin.py
Comment on lines +115 to +116
with contextlib.suppress(ValueError):
filesystempath = os.path.relpath(filesystempath)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryiii this lets Windows tests pass now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotate warnings as well?
2 participants
@edgarrmondragon @henryiii