Type-annotate dtypes.promote() #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `dtypes.promote()` is not typed. Fix it Differential Revision: D40330862 fbshipit-source-id: f1b02fcbd3efbf7e63e2b1bbc328241c226d9413
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40330862 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: #507 `dtypes.promote()` is not typed. Fix it Reviewed By: wenleix Differential Revision: D40330862 fbshipit-source-id: 343ff4398b42f3277df3f1779f16a455391be9e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
dtypes.promote()is not typed. Fix itDifferential Revision: D40330862