Merge pull request #17 from r7kamura/in-batches-inline-autocorrect

Prefer inline `in_batches` on `Migration/BatchInBatches` autocorrection
r7kamura · Jan 27, 2024 · b4c0686 · b4c0686
2 parents 8ade242 + 6b28d0d
commit b4c0686
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/lib/rubocop/cop/migration/batch_in_batches.rb b/lib/rubocop/cop/migration/batch_in_batches.rb
@@ -71,17 +71,7 @@ def autocorrect(
           corrector,
           node
         )
-          range = node.location.selector.with(
-            end_pos: node.source_range.end_pos
-          )
-          corrector.replace(
-            range,
-            <<~TEXT.chomp
-              in_batches do |relation|
-                relation.#{range.source}
-              end
-            TEXT
-          )
+          corrector.insert_before(node.location.selector, 'in_batches.')
         end
 
         # @param node [RuboCop::AST::SendNode]

diff --git a/spec/rubocop/cop/migration/batch_in_batches_spec.rb b/spec/rubocop/cop/migration/batch_in_batches_spec.rb
@@ -41,9 +41,7 @@ def change
       expect_correction(<<~RUBY)
         class BackfillUsersSomeColumn < ActiveRecord::Migration[7.0]
           def change
-            User.in_batches do |relation|
-          relation.update_all(some_column: 'some value')
-        end
+            User.in_batches.update_all(some_column: 'some value')
           end
         end
       RUBY
@@ -64,9 +62,7 @@ def change
       expect_correction(<<~RUBY)
         class BackfillUsersSomeColumn < ActiveRecord::Migration[7.0]
           def change
-            User.in_batches do |relation|
-          relation.delete_all
-        end
+            User.in_batches.delete_all
           end
         end
       RUBY