Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set action_mailer.default_url_options values in development and test #51191

Merged

Commits on Feb 26, 2024

  1. Set action_mailer.default_url_options values in development and `…

    …test`.
    
    Prior to this commit, new Rails applications would raise
    `ActionView::Template::Error` if a mailer included a url built with a
    `*_path` helper.
    
    Since we already know [new apps will be served on `localhost:3000`][new
    apps], we set this as the value in `development`.
    
    In an effort to remain consistent with existing patters, we set the
    `host` to `www.example.com` in `test.
    
    [new apps]: https://github.com/rails/rails/blob/47300002db11d67d7b35103f5c429dad7dacdacd/README.md?plain=1#L81
    stevepolitodesign committed Feb 26, 2024
    Copy the full SHA
    9412008 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Update railties/lib/rails/generators/rails/app/templates/config/envir…

    …onments/development.rb.tt
    
    Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
    stevepolitodesign and rafaelfranca committed Feb 27, 2024
    Copy the full SHA
    fc44197 View commit details
    Browse the repository at this point in the history