Support touch_all in batches
#51785
Merged
Support touch_all in batches
#51785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
touch_all-in-batches
branch
from
b42b602
to
38a6659
Compare
byroot
force-pushed
the
touch_all-in-batches
branch
from
38a6659
to
e057037
Compare
chaadow
reviewed
May 13, 2024
| assert_queries_count(6 + 6) do # 6 selects, 6 updates | ||
| Developer.in_batches(of: 2).touch_all(time: time) | ||
| end | ||
| assert_equal Developer.all.pluck(:updated_at), [time] * Developer.count |
There was a problem hiding this comment.
I think this should be
assert_equal(
[time] * Developer.count,
Developer.all.pluck(:updated_at)
)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ActiveRecord is missing the ability to run
touch_allvia batches (compared toupdate_all/delete_all/etc).