Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the scrolling issue occurring in mobile #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pplcallmesatz
Copy link

@pplcallmesatz pplcallmesatz commented Oct 18, 2021

We tried to scroll from the particular element in mobile it preventing to scroll. When we removed the e.preventDefault(); working fine for Us.

Thanks!

resolve #368

We tried to scroll from the particular element in mobile it preventing to scroll. When we removed the `e.preventDefault(); ` working fine for Us. 

Thanks!
@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tabs/5KTaUfMcRKF6PTeRB1vRXYzSREVF
✅ Preview: https://tabs-git-fork-pplcallmesatz-patch-1-react-component.vercel.app

@@ -30,8 +30,6 @@ export default function useTouchMove(

function onTouchMove(e: TouchEvent) {
if (!touchPosition) return;

e.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prevent by move direct instead. Not remove directly

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prevent by move direct instead. Not remove directly

What “prevent by move direct ” means?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For horizontal preventDefault with up & down but not block with left & right. And vertical is prevent up & down but not left & right.

Copy link

@Chorer Chorer Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For horizontal preventDefault with up & down but not block with left & right. And vertical is prevent up & down but not left & right.

It seems @pplcallmesatz didn't make some new commits. Why can't you just fix the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab bar prevents swipe up/down on mobile browser
3 participants