Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test change to check github action #2393

Conversation

Piotrfj
Copy link

@Piotrfj Piotrfj commented May 17, 2024

Summary:

Test Plan:

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@Piotrfj Piotrfj marked this pull request as ready for review May 17, 2024 11:29
@Piotrfj Piotrfj requested a review from cipolleschi as a code owner May 17, 2024 11:29
@Piotrfj Piotrfj force-pushed the fix/ignore-windows-github-action branch 2 times, most recently from ee6fa4e to 79a4876 Compare May 17, 2024 12:58
@Piotrfj Piotrfj force-pushed the fix/ignore-windows-github-action branch from 79a4876 to c469e9c Compare May 17, 2024 13:00
@szymonrybczak
Copy link
Collaborator

hey @Piotrfj :) could you please fill PR description if the PR is ready for review? If not please convert it to draft.

@TMisiukiewicz
Copy link
Collaborator

TMisiukiewicz commented May 20, 2024

@szymonrybczak the merged PR with skipping running actions on Windows doesn't seem to work correctly. GH actions were not running when in draft, so together with @Piotrfj we opened it to see if it works. We'll do some more tests today and let you know once it's ready for review

@Piotrfj
Copy link
Author

Piotrfj commented May 24, 2024

PR will be closed, the job in my opinion is impossible to do with this tool.

@Piotrfj Piotrfj closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants