Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: iOS video dimensions #2276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chocky335
Copy link

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the main branch, NOT a "stable" branch.

Motivation (required)

faced an issue with video dimensions on iOS(iPhone 11 Pro Max).

launchCamera({
        mediaType: "video",
        presentationStyle: 'fullScreen',
})
  1. call launchCamera
  2. film generic protrait video
  3. launchCamera returns:
{
    "assets": [
        {
            ...
            "type": "video/quicktime",
            "width": 1920,
            "height": 1080
        }
    ]
}

width = 1920 and height = 1080
should be
width = 1080 and height = 1920

Test Plan (required)

Portrait mode

  1. call launchCamera
  2. film generic portrait video
  3. check launchCamera return to match width & height to have the correct aspect ratio

Horizontal mode

  1. call launchCamera
  2. film generic horizontal video
  3. check launchCamera return to match width & height to have correct aspect ratio

Relevant issue - #2038
Original solution author - #2038 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant