Migrate to Github Actions and enable Linux/Windows builds #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawaramin
reviewed
Oct 27, 2020
There was a problem hiding this comment.
Hi, can you describe the behaviour of this CI setup in the following scenarios:
- Someone sends a PR–does something get built?
- Someone merges a commit to master
- Someone pushes a new tag
Also, how does a publish get triggered? I would prefer it to be on pushing a tag with a v prefix, e.g. pushing a tag v1.0.0 should trigger publishing to npm. Finally, I'm not sure if I missed it but I didn't see anything here that publishes to npm. Can you point me to the step that does that? Also I'll need to hook it up to my npm publish permissions...
|
|
||
| - name: Install Esy | ||
| run: | | ||
| npm install -g esy@0.6.2 |
There was a problem hiding this comment.
Can you change this to latest version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've been talking to @yawaramin about making this PR so don't think this is coming out of the blue 😄
The goal of this PR is to also distribute Linux/Windows binaries, not only MacOS. Since I have more experience with Github Actions I'm using that instead of Azure Pipelines.
With this in place, after each PR/commit against master, the pipeline will generate artifacts for each platform and one
releaseartifact including them all:The
releaseartifact is the one ready to be published in NPM and has the following structure:Inside the
platformsdirectory are the artifact for each platform, e.g.:After the package is installed:
postinstall.jsscript will be executed which will copy to the root folder the appropriate artifact depending on the current platform and archesyInstallRelease.jsscript of that artifact.I also have a published version at @anler/bsdoc that you can test directly if you need so.