Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older version of jsdom (<23) causes deprecation warnings #93

Closed
4 tasks done
stephenlrandall opened this issue Dec 18, 2023 · 5 comments · Fixed by #94
Closed
4 tasks done

Older version of jsdom (<23) causes deprecation warnings #93

stephenlrandall opened this issue Dec 18, 2023 · 5 comments · Fixed by #94
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done 🦋 type/enhancement This is great to have

Comments

@stephenlrandall
Copy link
Contributor

Initial checklist

Affected packages and versions

rehype-mathjax

Link to runnable example

No response

Steps to reproduce

Install rehype-mathjax with npm/pnpm/yarn

Expected behavior

No deprecated warnings

Actual behavior

The following deprecation warnings (pnpm):

 WARN  2 deprecated subdependencies found: abab@2.0.6, domexception@4.0.0

Both of these are used by older versions of jsdom (<23), but have been removed in jsdom v23 after being deprecated.

Runtime

No response

Package manager

pnpm

OS

macOS

Build and bundle tools

Vite

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 18, 2023
@ChristianMurphy ChristianMurphy added 🦋 type/enhancement This is great to have 📦 area/deps This affects dependencies labels Dec 18, 2023
@ChristianMurphy
Copy link
Member

ChristianMurphy commented Dec 18, 2023

Welcome @stephenlrandall! 👋
Warnings are not necessarily a bug, it still works and is secure 🙂
That said a PR upgrading JSDom to latest would also be welcome.

@stephenlrandall
Copy link
Contributor Author

Yeah, I wasn’t sure exactly what to classify this as. I’d be happy to provide a PR — I assume that all packages use this dependency, and there’s some test suite that should pass?

@ChristianMurphy
Copy link
Member

I assume that all packages use this dependency

only the rehype-mathjax package https://github.com/search?q=repo%3Aremarkjs%2Fremark-math%20jsdom&type=code

there’s some test suite that should pass?

Yes, running npm test runs a test suite, static analysis tools, and a type checker.

@stephenlrandall stephenlrandall mentioned this issue Dec 19, 2023
5 tasks
@stephenlrandall
Copy link
Contributor Author

@ChristianMurphy Opened #94. All tests passed.

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Dec 21, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Development

Successfully merging a pull request may close this issue.

3 participants