Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdom #94

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Update jsdom #94

merged 3 commits into from
Dec 21, 2023

Conversation

stephenlrandall
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Bumped the jsdom version to ^23.0.0 to avoid deprecation warnings from abab and domexception. Closes #93.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 19, 2023
@ChristianMurphy
Copy link
Member

Thanks @stephenlrandall!
It looks like version 23 raises the minimum node version to 18 https://github.com/jsdom/jsdom/releases/tag/23.0.0
Currently we support back to version 16, so I think this would be a major version bump

@ChristianMurphy ChristianMurphy added 🧑 semver/major This is a change 📦 area/deps This affects dependencies labels Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (260521f) 100.00% compared to head (4205d96) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1823      1823           
=========================================
  Hits          1823      1823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenlrandall
Copy link
Contributor Author

Thanks @stephenlrandall! It looks like version 23 raises the minimum node version to 18 https://github.com/jsdom/jsdom/releases/tag/23.0.0 Currently we support back to version 16, so I think this would be a major version bump

Bumped to lts/hydrogen -- is there anything else that would need to happen for a minimum node version bump?

@wooorm
Copy link
Member

wooorm commented Dec 20, 2023

I think it’s better to do update Node versions in a separate commit. Can you undo that change here? It’s indeed in different places. Don’t worry about it, I’ll take care of it!

@stephenlrandall
Copy link
Contributor Author

I think it’s better to do update Node versions in a separate commit. Can you undo that change here? It’s indeed in different places. Don’t worry about it, I’ll take care of it!

Undid the change. Thanks!

@wooorm wooorm changed the title Bump jsdom version Update jsdom Dec 21, 2023
@wooorm wooorm merged commit 4b8ebb9 into remarkjs:main Dec 21, 2023
2 checks passed

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Dec 21, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 21, 2023
@wooorm
Copy link
Member

wooorm commented Dec 21, 2023

thanks, released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done 🧑 semver/major This is a change
Development

Successfully merging this pull request may close these issues.

Older version of jsdom (<23) causes deprecation warnings
5 participants