Add helper for text color extention #1799
Conversation
|
| * Get the color for the selection | ||
| */ | ||
| @helper() | ||
| getTextColorForSelection(selection?: Selection): Helper<string> { |
There was a problem hiding this comment.
We should default to the current selection here, I believe
import { Selection } from '@remirror/core';| getTextColorForSelection(selection?: Selection): Helper<string> { | |
| getTextColorForSelection(selection: Selection = this.store.getState().selection): Helper<string> { |
| */ | ||
| @helper() | ||
| getTextColorForSelection(selection?: Selection): Helper<string> { | ||
| if (!selection) return this.options.defaultColor; |
There was a problem hiding this comment.
I suspect we need to check we have a text selection here?
import { isTextSelection } from '@remirror/core';| if (!selection) return this.options.defaultColor; | |
| if (!isTextSelection(selection) || selection.empty) { | |
| return this.options.defaultColor; | |
| } |
| getTextColorForSelection(selection?: Selection): Helper<string> { | ||
| if (!selection) return this.options.defaultColor; | ||
|
|
||
| const state = this.store.getState(); |
There was a problem hiding this comment.
This doesn't seem to be used?
|
|
||
| const state = this.store.getState(); | ||
| const textMarkInfo = getMarkRange(selection.$from, this.type); | ||
| if (!textMarkInfo) return this.options.defaultColor; |
There was a problem hiding this comment.
Formatting is a bit off here, suspect this would be fixed by running pnpm fix
| if (!textMarkInfo) return this.options.defaultColor; | |
| if (!textMarkInfo) { | |
| return this.options.defaultColor; | |
| } | |
Description
Added a helper to get the color from the current selection
Checklist
pnpm fixcompleted successfully.pnpm test.Screenshots