-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pathname stay when version changes in docs #263
Make pathname stay when version changes in docs #263
Conversation
Hey @nichtsam this is great! Thanks for adding this I noticed that there's one small bug. I think once this is fixed I'm good to merge this in undefined_route.mov |
I actually noticed the same thing, but the 'VersionWarningMessage' does this too, and I wasn't sure how to tackle this nicely. Throwing user to the main page when it's 404 seems a bit rude and unclear. |
Ah ok I didn't realize the bug in the url! 🤡 |
Haha sorry if I didn't make that clear. I imagine it's an easy fix, but ping me if it's not (or when you fix it!). Excited to merge 🙂 |
f76e0fe
to
6340628
Compare
@brookslybrand Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you @nichtsam
Currently switching branches or version throws users back to the index page.
I noticed that
VersionWarningMessage
preserves the path, so I just copied the logic over.