Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy types when using LOCAL_BUILD_DIRECTORY #8646

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jan 31, 2024

TODO

  • set chmod perms for node_modules/.bin/remix

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: e4f936a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

}
console.log("Writing rollup output to", appDir);
activeOutputDir = appDir;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we lose the yarn watch functionality if we do this since it calls rollup directly. There's a watch.onEnd script we could add the copy to though if we go this route

fse.copySync("build", appDir, { overwrite: true });
fse.chmodSync(path.join(appDir, "node_modules/.bin/remix"), 0o755);
}
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we lose the triggerLiveReload behavior if we just cp -r here? I believe we need to update one of the app files to trigger it, I don't think copying new files into node_modules as enough IIRC?

Should we be thinking about the vite cache here? Or should we just be using --force in our apps?

@brophdawg11
Copy link
Contributor

Maybe a better approach here to preserve yarn watch and live reload behavior would be to just do this full copy in a rollup writeBundle hook? That way it would preserve both of those existing behaviors?

@brophdawg11 brophdawg11 added the feat:dx Issues related to the developer experience label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed feat:dx Issues related to the developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants