New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy types when using LOCAL_BUILD_DIRECTORY #8646
base: dev
Are you sure you want to change the base?
Conversation
|
} | ||
console.log("Writing rollup output to", appDir); | ||
activeOutputDir = appDir; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we lose the yarn watch
functionality if we do this since it calls rollup directly. There's a watch.onEnd
script we could add the copy to though if we go this route
fse.copySync("build", appDir, { overwrite: true }); | ||
fse.chmodSync(path.join(appDir, "node_modules/.bin/remix"), 0o755); | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we lose the triggerLiveReload
behavior if we just cp -r
here? I believe we need to update one of the app files to trigger it, I don't think copying new files into node_modules
as enough IIRC?
Should we be thinking about the vite
cache here? Or should we just be using --force
in our apps?
Maybe a better approach here to preserve |
TODO
chmod
perms fornode_modules/.bin/remix