Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor Python dependencies #409

Open
bfirsh opened this issue Feb 8, 2022 · 2 comments · May be fixed by #1615
Open

Vendor Python dependencies #409

bfirsh opened this issue Feb 8, 2022 · 2 comments · May be fixed by #1615
Labels
help wanted Extra attention is needed
Projects
Priorities Cog v0.3.0

Comments

@bfirsh
Copy link
Member

bfirsh commented Feb 8, 2022 •
edited

This is bound to cause problems at some point colliding with user code.

We have some prior art for vendoring Python packages in Keepsake that works pretty well. I'm happy to have a go at booting up that code / transferring that knowledge if we want to do this.

Migrated from a todo in #378.
@bfirsh bfirsh added this to Backlog in Priorities via automation Feb 8, 2022
@zeke zeke added this to Must Have in Cog v0.3.0 Mar 21, 2022
@zeke zeke moved this from Must Have to Nice to Have in Cog v0.3.0 Mar 24, 2022
bfirsh added a commit that referenced this issue May 10, 2022
@bfirsh
Require typing-extensions>=4.1.0
d9b4d50 
See #593 (comment)

This will be properly fixed by
#409

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
This was referenced May 10, 2022
Merged
Merged
@bfirsh
Copy link
Member Author

bfirsh commented May 10, 2022

We probably also need to vendor typing-extensions. See #593 and #598.

bfirsh added a commit that referenced this issue May 11, 2022
@bfirsh
Require typing-extensions>=4.1.0
96d1a8f 
See #593 (comment)

This will be properly fixed by
#409

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
@bfirsh
Copy link
Member Author

bfirsh commented Jun 1, 2022 •
edited

More typing-extensions data... https://canary.discord.com/channels/775512803439280149/979390547477274644/981627994097467482

@bfirsh bfirsh added the help wanted Extra attention is needed label Jun 1, 2022
This was referenced Jun 21, 2022
Merged
Merged
@bfirsh bfirsh changed the title Vendor Pydantic and FastAPI Vendor Python dependencies Jun 28, 2022
@andreasjansson andreasjansson mentioned this issue Feb 1, 2023
Open
@andreasjansson andreasjansson mentioned this issue Apr 17, 2023
Closed
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 15, 2024
@andreasjansson
Vendor Python packages (take 2)
f476a24 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

This PR is broken up into two commits: First one adds all the files in the `_vendor` directory, second one is the actually changed code.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
@andreasjansson andreasjansson linked a pull request Apr 15, 2024 that will close this issue
Open
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
b1de0b3 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

This PR is broken up into two commits: First one adds all the files in the `_vendor` directory, second one is the actually changed code.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
735669b 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
597fe81 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
83ed417 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
da45327 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
f6deb3a 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 16, 2024
@andreasjansson
Vendor Python packages (take 2)
ddaef48 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson added a commit to andreasjansson/cog that referenced this issue Apr 17, 2024
@andreasjansson
Vendor Python packages (take 2)
c2d255b 
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library.

Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785).

Vendored packages are gitignored and are sync'd by the default `make` rule.

Closes replicate#409

Signed-off-by: andreasjansson <andreas@replicate.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
Priorities
Backlog
Cog v0.3.0
Nice to Have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vendoring (take 2) andreasjansson/cog
Vendor Python packages andreasjansson/cog
1 participant
@bfirsh