Vendoring (take 2) #1615
Open
Vendoring (take 2) #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andreasjansson
force-pushed
the
vendoring-take2
branch
6 times, most recently
from
06a32c7
to
77b5ff1
Compare
andreasjansson
requested review from
mattt,
nickstenning and
technillogue
and removed request for
nickstenning
|
Had a quick look at this and I think it could work. A couple of thoughts.
|
andreasjansson
force-pushed
the
vendoring-take2
branch
from
7d24da3
to
735669b
Compare
|
Great points @nickstenning. I've implemented your suggestions, much better! |
andreasjansson
force-pushed
the
vendoring-take2
branch
5 times, most recently
from
f6deb3a
to
ddaef48
Compare
This PR vendors all Python packages using the [vendoring](https://pypi.org/project/vendoring/) library. Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see replicate#1562, replicate#1384, replicate#1186, replicate#1586, replicate#1336, replicate#785). Vendored packages are gitignored and are sync'd by the default `make` rule. Closes replicate#409 Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson
force-pushed
the
vendoring-take2
branch
from
ddaef48
to
c2d255b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR vendors all Python packages using the vendoring library.
Vendoring allows users to install packages that rely on versions of libraries that are in conflict with Cog's dependencies (e.g. Pydantic, see #1562, #1384, #1186, #1586, #1336, #785).
Vendored packages are gitignored and are sync'd by the default
makerule.Closes #409