Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize webhook serialization #1592

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

technillogue
Copy link
Contributor

@technillogue technillogue commented Mar 24, 2024

this addresses some bottlenecks in models that output tokens fast

  • encode webhooks only after knowing they will be sent
  • bail out of upload type checks early for strs

Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
@technillogue technillogue marked this pull request as ready for review March 26, 2024 17:55
Signed-off-by: technillogue <technillogue@gmail.com>
@technillogue
Copy link
Contributor Author

this is missing a few things to get over the finish line, I'm not entirely sure how the mocking works, but should otherwise good to go

@technillogue technillogue requested a review from a team March 27, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant