Make style lookup consistent with clang-format #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version was using -style=file option only, causing failure if pwd != file's directory. 2 kinds of failures occur: - If no .clang-format is present in PWD, and one is present in the file's directory, then clang-format fails for lack of style file, and dump its error message directly into the buffer - If a .clang-format is present in PWD, and one is present in the file's directory, then the wrong .clang-format from PWD is used This commit makes the behavior fully consistent with clang-format: - lookup .clang_format in the file's directory and recursively go up its parent directory until found. If no style file is found, defaults to g:clang_format#style_options
arntanguy
force-pushed
the
fix-style-file
branch
from
cd271bb
to
47a10a7
Compare
|
My apologies, I should have looked at the documentation more carefully. |
|
I'm not sure you saw my answer regarding the versions of clang supporting this, so I'll write it here again. I'm not sure when it --assume-filename got introduced, but clang-3.4 (that you list as dependency in the README) definitely has it. Also in clang-format-3.6, there is a -fallback-style that can fallback to any of the preset styles (llvm, google...) if all else fails. This doesn't seem to be in 3.4, so I haven't used it for that pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version was only
directory
This behavior is quite problematic as it can easily lead to using the wrong .clang-format file, ie the one
in your current pwd instead of the one in the file's project. There are also some obvious cases
where the .clang-format file isn't found.
This commit makes the behavior fully consistent with clang-format:
its parent directory until found. If no style file is found, defaults
to g:clang_format#style_options
I don't really know the Viml language, so please double check if it's written the vim-way.