Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished video and audio merging for automated audio commentary over … #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JVPC0D3R
Copy link

…NBA Games

Description

This update introduces a significant refactoring of the existing code for extracting and comparing the durations of video and audio files using FFMPEG. The main goal of this change is to automate video and audio merging process.

Previously, the script utilized direct shell commands (!ffmpeg) for extracting durations. This update finishes and automates the merging process by incorporating the Python subprocess module and structuring the code into more manageable functions.

Dependencies

  • FFMPEG: This software needs to be installed and accessible in the system's PATH. FFMPEG is used for all media file manipulations.
  • Regular Expressions (re module in Python): Used for parsing the duration information from FFMPEG's output.

Type of Change

  • Code Refactoring (non-breaking change which improves the readability and structure of the code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

The refactoring primarily focuses on replacing inline shell commands with Python's subprocess module for better error handling and data processing. Additionally, the introduction of a dedicated function for duration extraction (get_duration) and

How has this change been tested, please provide a testcase or example of how you tested the change?

I've tested this change on several videos and audios, and also on the original NBA youtube video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant