Finished video and audio merging for automated audio commentary over … #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…NBA Games
Description
This update introduces a significant refactoring of the existing code for extracting and comparing the durations of video and audio files using FFMPEG. The main goal of this change is to automate video and audio merging process.
Previously, the script utilized direct shell commands (
!ffmpeg
) for extracting durations. This update finishes and automates the merging process by incorporating the Pythonsubprocess
module and structuring the code into more manageable functions.Dependencies
Type of Change
The refactoring primarily focuses on replacing inline shell commands with Python's
subprocess
module for better error handling and data processing. Additionally, the introduction of a dedicated function for duration extraction (get_duration
) andHow has this change been tested, please provide a testcase or example of how you tested the change?
I've tested this change on several videos and audios, and also on the original NBA youtube video.