Add some more fun to the homepage example #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I primarily want to rename the assigned variable to something other than `list`, to lead with something engaging that doesn't risk confusion with `List`. These changes seem to fit nicely, with only two extra characters of screen width consumption. However, I'm open to any changes that make this both more intuitive and fun. Signed-off-by: Jan Van Bruggen <JanCVanB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I primarily want to rename the assigned variable to something other than
list, to lead with something engaging that doesn't risk confusion withList. These changes seem to fit nicely, with only two extra characters of screen width consumption. However, I'm open to any changes that make this both more intuitive and more fun :)I don't like that this pushes the "Roc: A fast..." text slightly to the left, but I haven't read
www/well enough (yet?) to know how to improve that.