Deprecate Bundler constants #7653
Merged
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/deprecate-constants
branch
2 times, most recently
from
c2263d2
to
834256d
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/deprecate-constants
branch
from
834256d
to
6166e4b
Compare
hsbt
approved these changes
May 16, 2024
deivid-rodriguez
added a commit
that referenced
this pull request
May 16, 2024
…stants Deprecate Bundler constants (cherry picked from commit bf96fd1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Bundler has a constants.rb file that defines three constants but they seem rather arbitrary to me and they are mostly unused. I think we could deprecate them.
What is your fix for the problem, implemented in this PR?
Migrate the only used constant to RubyGems and deprecate the constants.
Make sure the following tasks are checked