Fix regression when caching gems from secondary sources

[deivid-rodriguez]

What was the end-user or developer problem that led to this PR?

If cache_all_platforms setting is enabled, the secondary source was no longer considering cached gems.

That means that if the remote secondary source has removed its gems, then this was now resulting in an error while before the previously cached gem from the source would still be used.

This is a regression from #7516.

What is your fix for the problem, implemented in this PR?

This commit restores previous behavior by explicit enabling cached gems when materializing gems for all platforms so that they can be cached in vendor/cache.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[honeyankit]

@deivid-rodriguez : Thank you for putting this. Is it possible to ship this tomorrow?

[deivid-rodriguez]

No problem! Yes, my idea is to ship a new release this week.

That said, I think upgrading Dependabot may be a bit of work. In particular, while looking into this issue, I noticed Dependabot relies on the @unlock[:gems] value in Bundler::Definition, which is now removed at initialize time since #7558.

[sachin-sandhu]

@deivid-rodriguez , do you have a release

No problem! Yes, my idea is to ship a new release this week.

That said, I think upgrading Dependabot may be a bit of work. In particular, while looking into this issue, I noticed Dependabot relies on the @unlock[:gems] value in Bundler::Definition, which is now removed at initialize time since #7558.

Hi @deivid-rodriguez ,
Is the release complete, if not, can you please share the # for us to keep track.

Thanks

[deivid-rodriguez]

Hei @sachin-sandhu! Sorry, I delayed last week release a bit because I saw some strange hang in CI and I was afraid it could be due to some recent change. But I haven't seen it anymore, either locally or in CI, so I'll move the release forward as planned. I'll try to wrap it up tomorrow.

[deivid-rodriguez]

Sorry once again for the delay here 🙏. I saw that hang again yesterday and I'm looking into it. Since this fix is a one liner, I would advice to monkeypatch the Bundler::SpecSet#materialize_for_all_platforms to get the fix for now. That way you don't need to block on the next Bundler release, nor on upgrading dependabot to use it, and can benefit from it inmediately.

[sachin-sandhu]

Sorry once again for the delay here 🙏. I saw that hang again yesterday and I'm looking into it. Since this fix is a one liner, I would advice to monkeypatch the Bundler::SpecSet#materialize_for_all_platforms to get the fix for now. That way you don't need to block on the next Bundler release, nor on upgrading dependabot to use it, and can benefit from it inmediately.

Thanks @deivid-rodriguez for the inputs, we are working on the monkey patch fix 👍🏻

[deivid-rodriguez]

No problem, sounds good, let me know if you find any issues!