-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUN-2464-Feat/unit test for activity filter #9124
Open
jayas006
wants to merge
6
commits into
main
Choose a base branch
from
feat/unit-test-for-activityFilter
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk hasn't found any issues so far.✅ code/snyk check is completed. No issues were found. (View Details) |
mrdubr
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very comprehensive!
export default defineComponent({ | ||
name: "ActivityFilter", | ||
components: { | ||
DateTimePicker, | ||
DateFilter, | ||
SavedFilters, | ||
}, | ||
props: ["eventBus", "modelValue", "eventBus", "opts"], | ||
props: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you so much for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
This is an enhancement. I have created activityFilter.spec.ts to ensure that the activityFilter component of our project functions correctly. This helps us maintain the integrity of the activityFilter component.
Describe the solution you've implemented
In the activityFilter.spec.ts file, I wrote tests to check different aspects of the activityFilter component. These tests help us identify potential issues early and ensure that changes to other parts of the project do not inadvertently affect the functionality of the activityFilter component.
Describe alternatives you've considered
Additional context
Creating these tests also helped me improve my TypeScript and Vue.js testing skills.