Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN-2464-Feat/unit test for activity filter #9124

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jayas006
Copy link
Contributor

@jayas006 jayas006 commented May 16, 2024

Is this a bugfix, or an enhancement? Please describe.
This is an enhancement. I have created activityFilter.spec.ts to ensure that the activityFilter component of our project functions correctly. This helps us maintain the integrity of the activityFilter component.

Describe the solution you've implemented
In the activityFilter.spec.ts file, I wrote tests to check different aspects of the activityFilter component. These tests help us identify potential issues early and ensure that changes to other parts of the project do not inadvertently affect the functionality of the activityFilter component.

Describe alternatives you've considered

Additional context
Creating these tests also helped me improve my TypeScript and Vue.js testing skills.

@jayas006 jayas006 marked this pull request as ready for review May 20, 2024 18:39
@pd-snyk-integration
Copy link

pd-snyk-integration commented May 20, 2024

🎉 Snyk hasn't found any issues so far.

code/snyk check is completed. No issues were found. (View Details)

Copy link
Contributor

@mrdubr mrdubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive!

export default defineComponent({
name: "ActivityFilter",
components: {
DateTimePicker,
DateFilter,
SavedFilters,
},
props: ["eventBus", "modelValue", "eventBus", "opts"],
props: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayas006
Copy link
Contributor Author

Very comprehensive!

Thank you so much for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants