New Runtime Features #145
New Runtime Features #145
Conversation
Fixed problems with releasing from Travis CI.
.travis.yml
Outdated
| file: disk/boot/runtime.gz | ||
| skip_cleanup: true | ||
| on: | ||
| repo: Ross-Computers/runtime |
There was a problem hiding this comment.
If you want your changes to be merged mainstream instead of create your own fork, you should left the repo references as they were before.
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # runtime.js | |||
|
|
|||
| [](https://travis-ci.org/runtimejs/runtime) [](https://www.npmjs.com/package/runtimejs) [](https://freenode.net/) [](https://gitter.im/runtimejs/runtime) | |||
| [](https://travis-ci.org/Ross-Computers/runtime) [](https://www.npmjs.com/package/runtimejs) [](https://freenode.net/) [](https://gitter.im/runtimejs/runtime) | |||
SConstruct
Outdated
| '-DV8_HOST_ARCH_X64', | ||
| '-DV8_TARGET_ARCH_X64', | ||
| '-DV8_HOST_ARCH_X'+bits, | ||
| '-DV8_TARGET_ARCH_X'+bits, |
There was a problem hiding this comment.
X64 is the arch name, not an indicator of the number of bits.
js/core/arch/x64/ps2/index.js
Outdated
| @@ -13,7 +13,7 @@ | |||
| // limitations under the License. | |||
There was a problem hiding this comment.
ps2 is not arch specific, so I would put it in a platform-agnostic folder, for example js/drivers/ps2.
js/core/index.js
Outdated
| const net = require('./net'); | ||
| const stdio = require('./stdio'); | ||
| const tty = require('./tty'); | ||
| const shell = require('./shell'); |
There was a problem hiding this comment.
All of these are drivers, so same as before. In fact, the shell is not a driver itself, but instead it's an app, so don't merge them.
js/core/shell/shell.js
Outdated
| this.CURSOR.X = this.CURSOR.Y = 0; | ||
| this.CURSOR.SHOWING = true; | ||
| this.WIDTH = width; | ||
| this.HEIGHT = height; |
There was a problem hiding this comment.
Cursor and sizes are dependent of the tty, not of the shell.
| @@ -16,11 +16,13 @@ | |||
| const keyboard = require('../keyboard'); | |||
There was a problem hiding this comment.
I would not consider tty part of core because it's build on top of keyboard and screen, so move it outside. It could be considered a driver, although not a low-level real one (because it's build on top of other ones) but instead a "virtual" one.
src/Includes/kernel/irqs.h
Outdated
| @@ -17,11 +17,7 @@ | |||
| #include <kernel/resource.h> | |||
There was a problem hiding this comment.
Rename folder from Includes to correct include (remove capital and plural).
|
Blocked-by: #156 |
Features: