feat: Implement assist to switch between doc and normal comments #17253
+702
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ThouCheese
force-pushed
the
master
branch
5 times, most recently
from
8390f72
to
51e6553
Compare
Veykril
reviewed
May 22, 2024
crates/ide-assists/src/handlers/convert_comment_from_or_to_doc.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_comment_from_or_to_doc.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_comment_from_or_to_doc.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_comment_from_or_to_doc.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_comment_from_or_to_doc.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_comment_from_or_to_doc.rs
Outdated
Show resolved
Hide resolved
Veykril
added
S-waiting-on-author
…nts anywhere, except for at the top of files.
Veykril
approved these changes
May 27, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey first PR to rust-analyzer to get my feet wet with the code base. It's an assist to switch a normal comment to a doc comment and back, something I've found myself doing by hand a couple of times.
I shamelessly stole
relevant_line_commentsfromconvert_comment_block, because I didn't see any inter-assist imports happening in the files I peeked at so I thought this would be preferable.