Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More callable info #17268

Merged
merged 5 commits into from
May 22, 2024
Merged

feat: More callable info #17268

merged 5 commits into from
May 22, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented May 21, 2024

With this PR we retain more info about callables other than functions, allowing for closure parameter type inlay hints to be linkable as well as better signature help around closures and Fn* implementors.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2024
@Veykril
Copy link
Member Author

Veykril commented May 22, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented May 22, 2024

📌 Commit 7bd343e has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 22, 2024

⌛ Testing commit 7bd343e with merge daf66ad...

@bors
Copy link
Collaborator

bors commented May 22, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing daf66ad to master...

@bors bors merged commit daf66ad into rust-lang:master May 22, 2024
11 checks passed
}

// pub fn parent_closure(&self) -> Option<Closure> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants