-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manual_unwrap_or_default
suggests error when expression is a None variant
#12688
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
dcaf974
to
1fd8241
Compare
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
988b08b
to
c6167c3
Compare
c6167c3
to
c9f0374
Compare
@y21 since you have already reviewed this, do you want to take it over? 😄 (Jarcho has SO many open PR assigned already, and judging by their contribution graph, I assume they might've been busy lately?) |
Suggesting error when expression is none :
None.unwrap_or_default()
raises an error, as explained in the following issue:fixes #12670
changelog: [
manual_unwrap_or_default
]: the lint is ignored when matching None, as theunwrap_or_default
method can't infer the type of a None variant.