Make for_each_expr
visit closures by default, rename the old version for_each_expr_without_closures
#12822
+148
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the time
for_each_expr
is picked when closures should be visited so I think it makes sense for this to be the default with the alternative available for when you don't need to visit them.The first commit renames
for_each_expr
tofor_each_expr_without_closures
andfor_each_expr_with_closures
tofor_each_expr
The second commit switches a few uses that I caught over to include closures to fix a few bugs
changelog: none