Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make for_each_expr visit closures by default, rename the old version for_each_expr_without_closures #12822

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Alexendoo
Copy link
Member

A lot of the time for_each_expr is picked when closures should be visited so I think it makes sense for this to be the default with the alternative available for when you don't need to visit them.

The first commit renames for_each_expr to for_each_expr_without_closures and for_each_expr_with_closures to for_each_expr

The second commit switches a few uses that I caught over to include closures to fix a few bugs

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants