Error for RPIT if they are not defined during MIR borrowck #125285

spastorino · 2024-05-19T18:21:57Z

There are some changes in tests that we would need to properly review. I've left some comments on each of them.

spastorino · 2024-05-19T18:23:06Z

tests/ui/impl-trait/divergence.rs

 fn foo() -> impl MyTrait {
+    //~^ ERROR: the trait bound `(): MyTrait` is not satisfied [E0277]


This is unfortunate but not sure how much we should care about this.

spastorino · 2024-05-19T18:24:13Z

tests/ui/impl-trait/impl_fn_associativity.rs

@@ -7,6 +6,7 @@ fn f_debug() -> impl Fn() -> impl Debug {
 }

 fn ff_debug() -> impl Fn() -> impl Fn() -> impl Debug {
+    //~^ ERROR: expected a `Fn()` closure, found `()` [E0277]


I'd need to properly check what's going on here but at a glance this regression seems wrong?

spastorino · 2024-05-19T18:24:36Z

tests/ui/impl-trait/nested_impl_trait.rs

    vec![|| println!("woot")].into_iter()
 }

 fn allowed_in_ret_type() -> impl Fn() -> impl Into<u32> {
+    //~^ ERROR: the trait bound `u32: From<()>` is not satisfied [E0277]


This is the only relevant change as the rest is rustfmt and seems fine.

spastorino · 2024-05-19T18:24:54Z

tests/ui/lint/unused/unused-supertrait.rs

@@ -1,11 +1,11 @@
 #![deny(unused_must_use)]

 fn it() -> impl ExactSizeIterator<Item = ()> {
+    //~^ ERROR the trait bound `(): ExactSizeIterator` is not satisfied [E0277]


This seems like a diagnostics regression.

compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs

spastorino · 2024-05-20T19:51:32Z

This is going to fail on https://github.com/rust-lang/rust/blob/master/tests/ui/impl-trait/in-trait/suggest-missing-item.fixed#L21 as cargo fix is going to add impls with todo!() for traits' methods which their return type is impl Trait, so it will produce a fixed rust file that is not going to compile.

spastorino · 2024-05-20T19:55:05Z

@bors try

…ode, r=<try> Error for RPIT if they are not defined during MIR borrowck r? `@lcnr` Fixes rust-lang#112417 There are some changes in tests that we would need to properly review. I've left some comments on each of them.

bors · 2024-05-20T19:56:18Z

⌛ Trying commit c130bfb with merge 5ff4501...

rust-log-analyzer · 2024-05-20T20:07:38Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


     Running tests/compile-test.rs (obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/compile_test-e0af1f18c1597357)

FAILED TEST: tests/ui/new_ret_no_self.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_config=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_config-c5e0235647f00232.rlib" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-2964c17de9728d6a.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-e7859c049d6fc5af.rlib" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-e1fa4d45c0e68db6.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-ae846d6788d6a9f1.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-e9aa61e1e4ee057e.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-3864f64671f03a2f.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-facaf493acd2f9ad.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-5689c7175177147d.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-d199b1d0494505d0.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-82c47a8e64b8c220.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-f7a5efbd7c1bc532.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-e9d338b744af34e7.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/tests/ui" "tests/ui/new_ret_no_self.rs" "--edition" "2021"
error: actual output differed from expected
Execute `cargo uibless` to update `tests/ui/new_ret_no_self.stderr` to the actual output
--- tests/ui/new_ret_no_self.stderr
+++ <stderr output>
+++ <stderr output>
-error: methods called `new` usually return `Self`
-  --> tests/ui/new_ret_no_self.rs:50:5
+  --> tests/ui/new_ret_no_self.rs:393:25
    |
    |
-LL | /     pub fn new(_: String) -> impl R<Item = u32> {
+LL |         fn new(t: T) -> impl Trait2<(), Self> {
+   |                         ^^^^^^^^^^^^^^^^^^^^^
 
 
-error: methods called `new` usually return `Self`
-  --> tests/ui/new_ret_no_self.rs:84:5
+  --> tests/ui/new_ret_no_self.rs:402:25
    |
-LL | /     pub fn new() -> u32 {
-LL | /     pub fn new() -> u32 {
+LL |         fn new(t: T) -> impl Trait2<(), i32> {
+   |                         ^^^^^^^^^^^^^^^^^^^^
 
 
-error: methods called `new` usually return `Self`
 
 
-error: methods called `new` usually return `Self`
-   |
-   |
-LL | /     pub fn new() -> (u32, u32) {
-LL | |         unimplemented!();
-LL | |     }
-   | |_____^
-
-
-error: methods called `new` usually return `Self`
-   |
-   |
-LL | /     pub fn new() -> *mut V {
-LL | |         unimplemented!();
-LL | |     }
-   | |_____^
-
-
-error: methods called `new` usually return `Self`
-   |
-LL | /     pub fn new() -> Option<u32> {
-LL | |
-LL | |         unimplemented!();
-LL | |         unimplemented!();
-LL | |     }
-   | |_____^
-
-error: methods called `new` usually return `Self`
-   |
-LL |         fn new() -> String;
-   |         ^^^^^^^^^^^^^^^^^^^
-
-
-error: methods called `new` usually return `Self`
-   |
-LL |         fn new(_: String) -> String;
-   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-
-error: methods called `new` usually return `Self`
-   |
-   |
-LL | /         fn new() -> (u32, u32) {
-LL | |             unimplemented!();
-LL | |         }
-   | |_________^
-
-
-error: methods called `new` usually return `Self`
-   |
-   |
-LL | /         fn new() -> *mut V {
-LL | |             unimplemented!();
-LL | |         }
-   | |_________^
-
-
-error: methods called `new` usually return `Self`
-   |
-   |
-LL | /         fn new(t: T) -> impl Into<i32> {
-LL | |             1
-LL | |         }
-   | |_________^
-
-
-error: methods called `new` usually return `Self`
-   |
-   |
-LL | /         fn new(t: T) -> impl Trait2<(), i32> {
-LL | |             unimplemented!()
-LL | |         }
-   | |_________^
-
-
-error: aborting due to 12 previous errors
-


error: `methods called `new` usually return `Self`` not found in diagnostics on line 50
   |
   |
51 |         //~^ ERROR: methods called `new` usually return `Self`
   |


error: ``-D clippy::new-ret-no-self` implied by `-D warnings`` not found in diagnostics on line 50
   |
   |
52 |         //~| NOTE: `-D clippy::new-ret-no-self` implied by `-D warnings`
   |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 84
   |
   |
85 |         //~^ ERROR: methods called `new` usually return `Self`
   |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 94
   |
   |
95 |         //~^ ERROR: methods called `new` usually return `Self`
   |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 131
    |
    |
132 |         //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 159
    |
    |
160 |         //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 178
    |
    |
179 |         //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 232
    |
    |
233 |         //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 245
    |
    |
246 |         //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 281
    |
    |
282 |             //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 309
    |
    |
310 |             //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 380
    |
    |
381 |             //~^ ERROR: methods called `new` usually return `Self`
    |


error: `methods called `new` usually return `Self`` not found in diagnostics on line 402
    |
    |
403 |             //~^ ERROR: methods called `new` usually return `Self`
    |

full stderr:
error: undefined opaque type
error: undefined opaque type
##[error]  --> tests/ui/new_ret_no_self.rs:393:25
   |
LL |         fn new(t: T) -> impl Trait2<(), Self> {

error: undefined opaque type
##[error]  --> tests/ui/new_ret_no_self.rs:402:25
   |
   |
LL |         fn new(t: T) -> impl Trait2<(), i32> {

error: aborting due to 2 previous errors

bors · 2024-05-20T21:38:48Z

☀️ Try build successful - checks-actions
Build commit: 5ff4501 (5ff4501f5e4c740f37756a1102c0b794291dddaf)

spastorino · 2024-05-20T22:15:48Z

@craterbot check

craterbot · 2024-05-20T22:15:54Z

👌 Experiment pr-125285 created and queued.
🤖 Automatically detected try build 5ff4501
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-05-23T05:46:56Z

🚧 Experiment pr-125285 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-05-25T02:37:34Z

🎉 Experiment pr-125285 is completed!
📊 502 regressed and 6 fixed (464331 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Add tests for unchecked region constraints for opaque types in dead code

1e7db2c

rustbot assigned lcnr May 19, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 19, 2024

spastorino commented May 19, 2024

View reviewed changes

spastorino force-pushed the unchk-region-opaque-deadcode branch from 854e723 to 6a7ad4c Compare May 19, 2024 18:34

lcnr reviewed May 19, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs Outdated Show resolved Hide resolved

spastorino force-pushed the unchk-region-opaque-deadcode branch from 6a7ad4c to 3e009ba Compare May 20, 2024 19:26

This comment has been minimized.

Sign in to view

If MIR doesn't define the opaque also fail for RPITs

c130bfb

spastorino force-pushed the unchk-region-opaque-deadcode branch from 3e009ba to c130bfb Compare May 20, 2024 19:50

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2024

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error for RPIT if they are not defined during MIR borrowck #125285

Error for RPIT if they are not defined during MIR borrowck #125285

spastorino commented May 19, 2024 •

edited

spastorino May 19, 2024

spastorino May 19, 2024

spastorino May 19, 2024 •

edited

spastorino May 19, 2024

This comment has been minimized.

spastorino commented May 20, 2024

spastorino commented May 20, 2024

bors commented May 20, 2024

rust-log-analyzer commented May 20, 2024

bors commented May 20, 2024

spastorino commented May 20, 2024

craterbot commented May 20, 2024

craterbot commented May 23, 2024

craterbot commented May 25, 2024

		fn foo() -> impl MyTrait {
		//~^ ERROR: the trait bound `(): MyTrait` is not satisfied [E0277]

Error for RPIT if they are not defined during MIR borrowck #125285

Are you sure you want to change the base?

Error for RPIT if they are not defined during MIR borrowck #125285

Conversation

spastorino commented May 19, 2024 • edited

spastorino May 19, 2024

Choose a reason for hiding this comment

spastorino May 19, 2024

Choose a reason for hiding this comment

spastorino May 19, 2024 • edited

Choose a reason for hiding this comment

spastorino May 19, 2024

Choose a reason for hiding this comment

This comment has been minimized.

spastorino commented May 20, 2024

spastorino commented May 20, 2024

bors commented May 20, 2024

rust-log-analyzer commented May 20, 2024

bors commented May 20, 2024

spastorino commented May 20, 2024

craterbot commented May 20, 2024

craterbot commented May 23, 2024

craterbot commented May 25, 2024

spastorino commented May 19, 2024 •

edited

spastorino May 19, 2024 •

edited