Sync reviewers from rust-lang/team #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to fill the reviewers dynamically if available. This introduces zero diff to the output.
`./target/release/thanks | xargs -I "{}" sed -i 's/"{}"/TO-DELETE/' src/reviewers.rs`
`gankro` now points at `grankra`, who is on team
`jonathandturner` now points at `jntrnr`, who is on team
`jyn514` is the real username of `jyn`
`rcvalle`'s contribution email seems to be
`rcvalle@users.noreply.github.com` as gathered from `git log`
https://git-scm.com/docs/gitmailmap#_syntax: > Both E-Mails and names are matched case-insensitively.
This is purely for local testing. If this change is desired, I will make a PR with this change to rust-lang/rust, pinging all the people as a FYI if desired.
|
I filled out the mailmap according to the following heuristics: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding everyone, pull in the people that are available there. We then only need to add aliases and additional reviewers, which should decrease the maintenance cost and increase accuracy. As #51 showed, this list here is not very well maintained.
This changes the email addresses for a bunch of people. I needed to add about 40 people to the mailmap (or ensure that they were here) to make it work. In the process, I also mailmapped a few other people that stood out like nrc, who's on thanks twice right now. The updated mailmap is currently committed in this PR, but I will make the change upstream and ping the involved people as a FYI if wanted if this PR is desired. I also had to change the mailmap code to compare names and emails case-insensitively as that caused some problems.
The output changed quite significantly as many clones were merged. I checked the top 100 contributors and after some additional fixes, none of them lost any contributions. It's entirely possible that a few people got split up but I think that's fine for now, as many other are already split up today and get fixed here. We or they can always try to fix it later.
This PR is best reviewed commit by commit, I tried making it as understandable as possible.