-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change S3Proxy from memory to filesystem storage #1665
base: master
Are you sure you want to change the base?
Conversation
It appears that S3Proxy filesystem backend doesn't handle Unicode paths properly:
|
@CarstenGrohmann I tweaked your |
895c927
to
5dd9bee
Compare
Something strange is going on -- I can get the CentOS 7 builder to pass but not the others. Also this works locally on my Fedora 34 desktop. So it seems Travis does something to the environment which confuses Java. |
@gaul If the problem is Locale, Github Actions Runner doesn't seem to have |
8565930
to
b1eb15d
Compare
Thanks for the hint! Now all the Linux builders succeed but macOS fails:
This may be a problem with S3Proxy; I will investigate. |
9896b56
to
2595074
Compare
I understand the macOS failures -- S3Proxy uses extended attributes to signify directories. Java on macOS lacks support for xattr before Java 17: https://bugs.openjdk.java.net/browse/JDK-8030048. We can upgrade the macOS builder when Homebrew upgrades to JDK 17 (probably in September). Future note to self: there are some |
This allows tests to pass in a Debian VM on Chromebook. References s3fs-fuse#1665.
This allows tests to pass using the S3Proxy filesystem provider. References s3fs-fuse#1665.
This allows tests to pass using the S3Proxy filesystem provider. References #1665.
f9dc6b4
to
56ed505
Compare
Homebrew recently updated to openjdk 17: https://formulae.brew.sh/formula/openjdk#default But it doesn't seem like this has propagated yet since Travis fails. |
Seems like the GitHub-supported way to due this is currently blocked on actions/runner-images#4085. |
Also blocked by gaul/s3proxy#396. |
4c49eff
to
3672139
Compare
Something strange here -- brew reports:
but
|
2c3aee9
to
5065ca2
Compare
I tried this suggestion but it didn't work:
This is a little complicated for me to debug since my MacBook 2010 cannot use the latest Homebrew. Maybe #1851 is easier? |
@gaul
|
e4927ff
to
f8ea4b8
Compare
This should avoid OutOfMemoryErrors seen with larger object sizes. Enabled by fixes in S3Proxy 2.0.0. Also change LC_ALL to en_US.UTF-8 and add locales packages so that S3Proxy can create Unicode file names. This commit requires Java 17 on macOS to allow creating extended attributes for directories.
f8ea4b8
to
430f29c
Compare
Some tests fail due to overfull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should avoid
OutOfMemoryError
s seen with larger object sizes.Enabled by fixes in S3Proxy 2.0.0. Also change
LC_ALL
toen_US.UTF-8
and add locales packages so that S3Proxy can create Unicode file
names. This commit requires Java 17 on macOS to allow creating
extended attributes for directories.