workaround for WiseLibs/better-sqlite3#1032

creates a binding dictionary explicitly on JS, zipping the arguments with their index and binding str(idx+1) to the argument
s5bug · Mar 23, 2024 · 8ce752b · 8ce752b
1 parent 44337cd
commit 8ce752b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/core/js/src/main/scala/porcupine/dbplatform.scala b/core/js/src/main/scala/porcupine/dbplatform.scala
@@ -52,7 +52,12 @@ private abstract class DatabasePlatform:
                       def cursor(args: A): Resource[F, Cursor[F, B]] = mutex.lock *>
                         Resource
                           .eval {
-                            F.delay(statement.iterate(bind(args)*)).map { iterator =>
+                            val argsList = bind(args)
+                            val argsDict: js.Dictionary[Any] =
+                              js.Dictionary(argsList.zipWithIndex.map { case (v, idx) =>
+                                (s"${idx + 1}", v)
+                              }*)
+                            F.delay(statement.iterate(argsDict)).map { iterator =>
                               new:
                                 def fetch(maxRows: Int): F[(List[B], Boolean)] =
                                   F.delay {
@@ -90,7 +95,12 @@ private abstract class DatabasePlatform:
                     new AbstractStatement[F, A, B]:
                       def cursor(args: A): Resource[F, Cursor[F, B]] =
                         mutex.lock *> Resource.eval {
-                          F.delay(statement.run(bind(args)*)).as(_ => F.pure(Nil, false))
+                          val argsList = bind(args)
+                          val argsDict: js.Dictionary[Any] =
+                            js.Dictionary(argsList.zipWithIndex.map { case (v, idx) =>
+                              (s"${idx + 1}", v)
+                            }*)
+                          F.delay(statement.run(argsDict)).as(_ => F.pure(Nil, false))
                         }
 
                 }

diff --git a/core/js/src/main/scala/porcupine/facade.scala b/core/js/src/main/scala/porcupine/facade.scala
@@ -37,6 +37,7 @@ private[porcupine] trait Statement extends js.Object:
 
   def raw(toggleState: Boolean): Statement = js.native
 
-  def iterate(bindParameters: Any*): js.Iterator[js.UndefOr[js.Array[Any]]] = js.native
+  def iterate(bindParameters: js.Dictionary[Any]): js.Iterator[js.UndefOr[js.Array[Any]]] =
+    js.native
 
-  def run(bindParameters: Any*): js.Object = js.native
+  def run(bindParameters: js.Dictionary[Any]): js.Object = js.native