fix: implement stylesheet registration and disallow arbitrary functions #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (#3443) * fix: implement stylesheet registration and disallow arbitrary functions * feat: log as error and use reporting API * fix: move to dev-only warning, address PR comments * fix: add test to verify existing behavior is maintained * fix: only import registerStylesheet if new styles were compiled
nolanlawson
approved these changes
May 2, 2023
|
/nucleus test |
divmain
approved these changes
May 2, 2023
nolanlawson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3443
fix: implement stylesheet registration and disallow arbitrary functions
feat: log as error and use reporting API
fix: move to dev-only warning, address PR comments
fix: add test to verify existing behavior is maintained
fix: only import registerStylesheet if new styles were compiled
Details
Reverts 5e9ee50.
This PR is blocked due to the version mismatch issue with CLWR and cannot be merged/released until that issue is resolved. Once a component's stylesheets are compiled with the new
registerStylesheetAPI, it will expect the runtime to have that method. To do that, the runtime and compiler versions must both be upgraded.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item