chore: update engines.node version to v16 #4188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
changed the title
wjhsf
approved these changes
May 1, 2024
nolanlawson
requested changes
May 1, 2024
There was a problem hiding this comment.
It's a bit confusing, but the engines version in the root package.json doesn't actually do anything for consumers. It only affects us and our CI tests and local dev machines.
I would recommend modifying check-and-rewrite-package-json.js to read from the root package.json file and write the engines into each of our sub-packages.
|
Ugh, I just realized that the |
|
Deferred to LWC v8.0.0 so that we can bump directly to Node v18 or v20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
v18.18.0 seems like a reasonable minimum supported node version considering our project doesn't build successfully using anything below that.Conservatively update to v16 since our internal systems are still in the process of migrating to v18/v20.
Does this pull request introduce a breaking change?
GUS work item
W-15647787